[MPlayer-dev-eng] [SURVEY] change mencoder's default ofilename extension?

[Reynaldo H. Verdejo Pinochet]

On Wed, Dec 14, 2005 at 08:29:32AM +0200, Oded Shimon wrote:
> On Tue, Dec 13, 2005 at 06:01:14PM -0300, Reynaldo H. Verdejo Pinochet wrote:
> > @@ -170,7 +170,7 @@
> >  unsigned int vobsub_out_index=0;
> >  char *vobsub_out_id=NULL;
> >  
> > -char* out_filename="test.avi";
> > +char* out_filename="";
> >  
> >  char *force_fourcc=NULL;
> >  int force_audiofmttag=-1;
> > @@ -465,6 +465,31 @@
> >   filelist = m_config_parse_me_command_line(mconfig, argc, argv);
> >   if(!filelist) mencoder_exit(1, MSGTR_ErrorParsingCommandLine);
> >  
> > +	if (!strlen(out_filename)) mencoder_exit(1,MSGTR_MissingOutputFilename);
> >
> > [...]
> 
> You still haven't done the NULL thing i told, out_filename needs to be 

I just did not want to.

> NULL on init, and you need to check for it being non null, not strlen.

strlen has no problem there, but now what?  Ill not argue, I dont
really care. this is just a matter of taste, I dont maintain mencoder.c
so Im just going to accept any suggestion that dont break the *almost*
agreement we have.

> 
> Here's a fixed patch.
> 

Thanks.

  Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051214/7aec3761/attachment.pgp>