[MPlayer-dev-eng] [PATCH] remove limits from af_equalizer

[Reynaldo H. Verdejo Pinochet]

On Fri, Dec 09, 2005 at 08:11:41PM -0800, Corey Hickey wrote:
> 
> Sorry this took me so long -- I got caught up in preparing for the Doom9
> codec comparison and had to set this aside for a while.

No prob

> 
> The application of my other patch to af_equalizer (which removed an
> unnecessary divide by 40) makes af_equalizer way more sensitive than it
> used to be. Useful values are only between -2 and 2, whereas they should
> be between -12 and 12. Setting a suboption to 3 shouldn't cause
> out-of-range values. I don't think my other patch was wrong, but I think
> it only fixes half the bug. I spent a while looking at af_equalizer.c,
> but I didn't find a solution. I can understand the source ok, but I
> don't know how it should be.
> 
> I wanted to fix it myself before I sent in another patch removing the
> limits, but at this point I have to give up. As it is right now, with
> af_equalizer's sensitivity, the limits are way higher than they need to
> be anyhow. If that bug is fixed, then my previous patch
> (equalizer-remove-limits2.diff) will probably be relevant. Otherwise,
> you might as well drop it.
 
I will try to figure out whats happening, thanks por pointing this
out I didnt notice it.

> -Corey

  Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051210/93f0296f/attachment.pgp>