[MPlayer-dev-eng] [PATCH] fix for Xv when shared memory allocation failed

[Alexander Strasser]

Hi,

The Wanderer wrote:
> Alexander Strasser wrote:
> >joerg at britannica.bec.de wrote:
> >
> >>attached fixes a problem with the initialisation of Xv. When the
> >>shmget failed, libX11 would abort due to invalid parameters. This
> >>can happen e.g. on NetBSD with the GENERIC kernel and PostgreSQL
> >>running in the background. Ideally the shmat would be checked too,
> >>but that would make the patch more messy.
> >
> >Patch looks correct so far but the same code is more or less
> >duplicated in vo xvmc with missing error check too. Unfotunately
> >there is no easy way to merge the two. I would say making the same
> >change in vo_xvmc.c is the way to go for now.
> 
> Any other comments?
> 
> If not, since no one's spoken up against it, I'll apply this patch and
> make similar changes to vo_xvmc.c as well within the next few days.

  OK for me, thanks.
  I recently had an idea how to fix this better, maybe I can implement
it before you commit and spare you some work.

  Alex (beastd)