[MPlayer-dev-eng] Re: [PATCH] OSD localization third try

[The Wanderer]

Tobias Diedrich wrote:

> Reimar Döffinger wrote:
> 
>> On Mon, Nov 07, 2005 at 07:40:41PM +0100, Tobias Diedrich wrote:
>> 
>>> Well, the code enabled by this only deals with UTF8, other
>>> multibyte encodings are entirely different beasts.  I'll rewrite
>>> it to use iconv when I find the time (Maybe Wednesday).
>> 
>> Keep in mind that e.g. MinGW does not have iconv, so IMHO avoid it
>> if at all possible,
> 
> Ok, so how about a simple iconv implementation for osdep?
> See attached patch (Note: I know the configure check is lacking.
> i.e. IIRC at least on Solaris -liconv is needed).
> For MinGW maybe it could be extended to use native Windows charset
> conversion functions.

Any comments on this patch?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.