[MPlayer-dev-eng] [PATCH] charset checking for TOOLS/checktree.sh

[The Wanderer]

Ivo wrote:

> On Monday 05 December 2005 01:29, The Wanderer wrote:

>> Another week-plus later without any comments: the patch looks okay
>> to my (comparatively inexperienced) eyes, still applies without
>> errors, and appears to behave correctly; I'll commit it in a day or
>> two if no one speaks up against it.
> 
> I created this small patch so it was easier to have Reimar's patch
> conform to some sort of standard. Like, see which files do not comply
> to a certain rule and (with this switch) see which lines of those
> files are "wrong". I am the author of the original script and I think
> that is a Good Thing :)
> 
> Although Reimar did not update his patch yet, I think my patch can be
>  applied. I can do it myself, but if you want, you can do it too.

Hmm. Okay, I've been negligent; I hadn't realized that this patch did
not supersede Reimar's. If he decides to update his patch and
incorporate this, I'll drop this one; if he doesn't, I'll apply this in
the near future unless you beat me to it.

> BTW should I list myself as maintainer for this script? I didn't know
> if I had to for scripts in TOOLS.

You're already listed in TOOLS/README as the maintainer for
checktree.sh... and judging by what's already there, I don't think you
need to mention it in MAINTAINERS. Certainly the other scripts in TOOLS
don't seem to be referred to there.

>> (Although, I'll note, there is apparently one UNHOLY SHITLOAD of
>> trailing whitespace in the source tree...)
> 
> Yes :)

It occurs to me that there's actually probably too much. Do we really
want to consider a line which consists only of whitespace as containing
"trailing whitespace"? There are quite a number of such lines in the
tree, and at least one file for which that is the only type of line
which ends with whitespace.

> And sorry for taking so long to reply. I had forgotten about this
> completely and am quite busy atm.

Eh, 'sall good. As for the "forgotten" part, that's why we want someone
to specifically keep track of the patches in the first place, isn't it?
^_^

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.