[MPlayer-dev-eng] [PATCH] Correctly set optimization flag for Athlon. Closes Bug #267

[Diego Biurrun]

On Thu, Dec 01, 2005 at 09:32:17AM +0800, Zuxy Meng wrote:
> 
> 2005/12/1, Diego Biurrun <diego at biurrun.de>:
> > On Wed, Nov 30, 2005 at 01:13:51PM +0800, Zuxy Meng wrote:
> > >
> > >      6) iproc=686
> > > +     # It's a bit difficult to determine the correct type of AMD's CPUs
> > > +     # of Family 6 only from its signature.
> >
> > The second part of this sentence no verb and thus difficult to.
> 
> My English is bad...Someone might rewrite this comment?

Your English is not bad at all.

Anyway, if I understand correctly what you are trying to say then

  It is a bit difficult to determine the correct type of Family 6 AMD
  CPUs just from their signature.

should do the trick.

> > > -    *) proc=athlon-xp iproc=686 ;;
> > > +    *) proc=k8 iproc=686 ;;
> >
> > Sure about this?  Here's what I have in the gcc manual page:
> >
> >   k8, opteron, athlon64, athlon-fx
> >     AMD K8 core based CPUs with x86-64 instruction set support. (This
> >     supersets MMX, SSE, SSE2, 3dNOW!, enhanced 3dNOW! and 64-bit
> >     instruction set extensions.)
> 
> All known AMD families are explicitly listed in configure, *) is for
> the future:-) Hopefully AMD's upcoming CPUs won't remove any
> preexisting features.

On second thought it should be OK since our current fallback, athlon-xp,
is not very conservative either.

Send in an updated patch that features my fixed comment (in case I
understood you correctly) and I'll apply.

Diego