[MPlayer-dev-eng] Re: [PATCH] Seek in http-streams
Valentine Zaretsky
valik+mplayerdev at email.dp.ua
Sat Jan 31 18:57:57 CET 2004
Hi!
Is the patch acceptable now or should I fix something?
--
Best regards, Valentine
Valentine Zaretsky wrote:
> Alban Bedel wrote:
>
>>> On Wed, 21 Jan 2004 15:24:46 +0200
>>> Valentine Zaretsky <valik+mplayerdev at email.dp.ua> wrote:
>>>
>>>
>>>> You are right, http_send_request2 is odd.
>>>> I've removed it in attached patch.
>>>>
>>>
>>> Any comments on this patch ?
>>>
>>
>>
>> Yes, the parts wich replace demux->stream->type!=STREAMTYPE_STREAM
>> with (demux->stream->type!=STREAMTYPE_STREAM || demux->stream->seek).
>> Using demux->stream->seek only should be enouth and better. Bcs using
>> stream type to determine if a stream is seekable just plain suck.
>>
>>
>>
> Ok. Now I replaced (demux->stream->type!=STREAMTYPE_STREAM) with
> (demux->stream->flags & STREAM_SEEK).
> Even better, IMHO.
> Everything else is OK now?
>
More information about the MPlayer-dev-eng
mailing list