[MPlayer-dev-eng] Re: [PATCH] 422p rawvideo in plus rawuyvy out

[John Earl]

On Thu, 2004-01-29 at 16:50, D Richard Felker III wrote:
> On Thu, Jan 29, 2004 at 11:54:14AM +0100, Attila Kinali wrote:
> > On Wed, 21 Jan 2004 12:00:43 +0000
> > John Earl <jwe21 at cam.ac.uk> wrote:
> > 
> > > > Then please, add more format. We are not going to do 2000 little commits.
> > > > Take the code in mp_image.h dump the size calculation for ALL know
> > > > formats and send one patch, once. I'm not willing to review each colorspace
> > > > addition to rawvideo one by one.
> > > 
> > > Done (mplayer-rawvideo, attached).
> > > 
> > > Am re-attaching the rawuyvy output patch (useful since there isn't yet
> > > any 4:2:2 colorspace raw output available).
> > 
> > Any comments on this patch ?
> 
> Yes, it's nonsense. We don't need 20 different "raw*" ovc's. Instead
> make one ve_raw that supports any format...

As requested.

mplayer-raw-out.patch : removes the 'rawyuv' ovc and replaces it with a
new 'raw' ovc which has associated commandline option -rawopts with
parameter fourcc to specify what format to output e.g., 

mencoder test.avi -ovc raw -rawopts fourcc=RGB16 -o test.rgb16.avi
mencoder test.avi -ovc raw -rawopts fourcc=I420 -o test.i420.avi
 etc

If no fourcc is specified, then no conversion is forced (equivalent to
the copy ovc)

Is it right to remove the 'rawyuv' ovc? Would it be better to remove the
'rawrgb' ovc as well? I was unsure since the comment in ve_rawrgb.c is
"for internal use in mencoder" which suggests it might be used
elsewhere.

and again:

mplayer-rawvideo.patch : adds a reasonably full set of size calculations
for the rawvideo input codec

John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-raw-out.patch
Type: text/x-patch
Size: 12724 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040130/6f7dfdd3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-rawvideo.patch
Type: text/x-patch
Size: 2207 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040130/6f7dfdd3/attachment-0001.bin>