[MPlayer-dev-eng] Re: [MPlayer-users] [BUG] Bottom row of YV12 has wrong/mixed chroma channels when using software scaler + conversion to RGB( NODAEMON and NOVIRUS)

[Michael Niedermayer]

Hi

On Friday 23 January 2004 23:29, Diego Biurrun wrote:
> Michael Niedermayer writes:
>  > On Friday 23 January 2004 21:54, Diego Biurrun wrote:
>  > > Michael Niedermayer writes:
>  > >  > On Wednesday 21 January 2004 22:18, Diego Biurrun wrote:
>  > >  > > Michael Niedermayer writes:
>  > >  > >  > cvs -z3 up -r 1.21 yuv2rgb.c
>  > >  > >  >
>  > >  > >  > btw, should i fix this with 'cvs admin' or commit the old
>  > >  > >  > version over it? IIRC there where problems with late reverses,
>  > >  > >  > but that was with the cvsbackup thing, not cvs admin
>  > >  > >
>  > >  > > Well, cvs admin sure worked for me.
>  > >  >
>  > >  > just tried locally, it doesnt work (reverse + commit alternative ->
>  > >  > cvs up doest update to the new version)
>  > >
>  > > Hmm, I have definitely done it before and it worked.  cvs admin is
>  > > somewhat of a hack though.  Maybe you have to remove the file and do
>  > > cvs update so that the metadata for the file is updated, cvs might
>  > > think that it already has the latest version.
>  >
>  > sure but what i was trying to say is that _users_ wont have the correct
>  > version after cvs admin & cvs commit if they had the removed version,
>  > and yes, rm & cvs up should fix it but how should a user know that, if
>  > for example the ppl in the movie have blue faces?
>
> I have reversed commits in my devel tree and the changes did show up
> in my scratch tree after I did "cvs update -dPA" there.  The file
> showed up as
>
> U whatever_the_filename_was
>
> instead of
>
> P whatever_the_filename_was
>
> however, but it definitely worked.
hmm, did u also commit a new version before cvs up? it doesnt work here, see:

michael at MichaelsNB:~/cvs-test/test$echo 1 > test.c
michael at MichaelsNB:~/cvs-test/test$cvs add test.c
cvs add: scheduling file `test.c' for addition
cvs add: use 'cvs commit' to add this file permanently
michael at MichaelsNB:~/cvs-test/test$cvs commit test.c
...
initial revision: 1.1
done
michael at MichaelsNB:~/cvs-test/test$echo 2 > test.c
michael at MichaelsNB:~/cvs-test/test$cvs commit test.c
...
new revision: 1.2; previous revision: 1.1
done
michael at MichaelsNB:~/cvs-test/test$cd ~/cvs-test2/test/
michael at MichaelsNB:~/cvs-test2/test$cvs up    
cvs update: Updating .
U test.c
michael at MichaelsNB:~/cvs-test2/test$cd ~/cvs-test/test
michael at MichaelsNB:~/cvs-test/test$cvs admin -o1.2 test.c
RCS file: /home/michael/cvsroot/blah/test/test.c,v
deleting revision 1.2
done
michael at MichaelsNB:~/cvs-test/test$echo 2-new > test.c
michael at MichaelsNB:~/cvs-test/test$cvs commit test.c
cvs [commit aborted]: could not find desired version 1.2 in 
/home/michael/cvsroot/blah/test/test.c,v
michael at MichaelsNB:~/cvs-test/test$rm test.c
michael at MichaelsNB:~/cvs-test/test$cvs up -dPA
cvs update: Updating .
cvs update: warning: test.c was lost
U test.c
michael at MichaelsNB:~/cvs-test/test$echo 2-new > test.c
michael at MichaelsNB:~/cvs-test/test$cvs commit test.c
...
new revision: 1.2; previous revision: 1.1
done
michael at MichaelsNB:~/cvs-test/test$cd ~/cvs-test2/test/
michael at MichaelsNB:~/cvs-test2/test$cvs up -dPA
cvs update: Updating .
michael at MichaelsNB:~/cvs-test2/test$cat test.c
2

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en