[MPlayer-dev-eng] Re: [MPlayer-users] [BUG] Bottom row of YV12 has wrong/mixed chroma channels when using software scaler + conversion to RGB (NODAEMON and NOVIRUS)

[Michael Niedermayer]

Hi

On Saturday 17 January 2004 20:26, D Richard Felker III wrote:
> On Fri, Jan 16, 2004 at 08:52:49PM -0500, Matthew W. Miller wrote:
> > I have found that, with recent MPlayer CVS snapshots (since
> > MPlayer-20031228), when using the software scaler to resize and convert
> > from YV12 to RGB formats (either BGR16, which is the SVGA mode I use, or
> > BGR32, for XFree86), the bottom row of chroma (that is, the bottom two
> > rows of the picture) is discoloured.  Reddish things look blue-tinted,
> > and bluish things look red-tinted, which suggests to my
> > (non-programmming-inclined) mind that either the R and B channels, or
> > the U and V channels, are somehow being swapped.
> > 	This does not seem to happen when *just* converting colorspace,
> > but only when scaling to a different size.  I tried every -sws option
> > from 0 up to 10 and seen the same 'swapping' in all of them.
>
> My guess would be that alternate/C code is used for the bottom line of
> the image, and a bugfix that was applied to that code never made it
> into the specialized last-line code. Can someone who understands
> swscaler code confirm this (and hopefully fix it)?
cvs -z3 up -r 1.21 yuv2rgb.c

btw, should i fix this with 'cvs admin' or commit the old version over it? 
IIRC there where problems with late reverses, but that was with the cvsbackup 
thing, not cvs admin

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en