[MPlayer-dev-eng] [PATCH] ppc jumbo patch
Romain Dolbeau
dolbeau at irisa.fr
Mon Jan 19 18:39:48 CET 2004
Diego Biurrun wrote:
> Romain Dolbeau writes:
> > 2) liba52 patch, with AltiVec resampler
> >
> > --- liba52/Makefile 11 Aug 2003 20:52:50 -0000 1.9
> > +++ liba52/Makefile 19 Jan 2004 09:31:13 -0000
> > @@ -19,7 +19,7 @@
> > $(AR) r $(LIBNAME) $(OBJS)
> >
> > test: $(LIBNAME) test.c
> > - $(CC) $(CFLAGS) test.c ../cpudetect.c -o test ./liba52.a -lm
> > + $(CC) $(CFLAGS) test.c ../cpudetect.c ../mp_msg.c -o test ./liba52.a -lm
>
> Doesn't this add an MPlayer dependency to an external library? I
> thought mp_msg should not be used in external libs to avoid making
> backporting unnecessarily hard.
cpudetect.c use mp_msg(), so it doesn't link without
mp_msg.c . The liba52 in ffmpeg doesn't include
the Makefile or test.c . Are they part of the
"standard" external library ?
--
Romain Dolbeau
More information about the MPlayer-dev-eng
mailing list