[MPlayer-dev-eng] [PATCH] (UPDATED) vf_bmovl2, complete and documented
Diego Biurrun
diego at biurrun.de
Fri Jan 16 16:30:44 CET 2004
Here are some suggestions for the documentation part of your patch:
First off, please use only one space after each '.', that's the
European style we use throughout the documentation.
Jason Tackaberry writes:
> --- main.orig/DOCS/tech/vf_bmovl2.txt 1969-12-31 19:00:00.000000000 -0500
> +++ main/DOCS/tech/vf_bmovl2.txt 2004-01-11 17:20:03.000000000 -0500
> @@ -0,0 +1,147 @@
> +vf_bmovl2 - BitMap OVerLay Video Filter -- version 2
> +====================================================
> +
> +Introduction
> +------------
> +
> +bmovl2 is an MMX-optimized filter that allows you to feed any number of
> +images (bitmaps) to MPlayer via a fifo, and instruct MPlayer how to
I would suggest you say 'FIFO' everywhere..
> +render these images over top the video window. Each image sits on its
Huh? Do you mean ".. on top of the video .."?
> +commands to manipulate layers take the layer's id as an argument.
I'd suggest 'ID', same below.
> + coordinates (0,0), full alpha (255), and zindex of 0.
z-index
> +VISIBLE id visibility
> + - Sets visibility of the specified layer referenced by id. Visibility
> + is 0 to hide, or 1 to show.
> +
> +MOVE id x y
> + - Move the layer with id to coordinates x, y
- Move the layer id to coordinates x, y.
> + channel in between frames. Mplayer waits until it receives
MPlayer
> +bmovl2 is an MMX-optimized filter that allows you to feed any number of
> +images (bitmaps) to MPlayer via a fifo, and instruct MPlayer how to render
> +these images over top the video window in real-time.
Again, do you mean ".. on top of the video .."?
> +For information about the command protocol, which is an enhancement of the
> +original bmovl, read DOCS/tech/vf_bmovl2.txt
Don't forget the ending '.'
Diego
More information about the MPlayer-dev-eng
mailing list