[MPlayer-dev-eng] [PATCH] new C only matroska demuxer

[Moritz Bunkus]

Heya,

> First, I've not made any copy/paste from gstreamer (AFAIR), I only
> took some inspiration in it (mostly for the ebml part).

Well, some of the ebml functions looked rather c&ped to me, but I may be
wrong as I haven't looked at it too long.

> But anyway it don't seem to be a problem, as stated in the LGPL :

...

Ok, I don't know the LGPL all that well, so this seems ok.

> What do you mean by "unify the syntax" ?

Just minor things like placing opening { on a new line everywhere.

> > This ain't official - although mkvmerge can use lzo compression as
> > well, but don't expect it to work anywhere else.
> 
> Ok, but anyway supporting it won't hurt, i guess :-)

The problem is that I've seen at least two more or less big problems
with your code so far (note that I still haven't compiled it, that'll
have to wait until the weekend), and I don't have time maintaining two
nearly identical demuxers. It's too error prone...

> I agree with this but I thought that it would be safer to keep the
> two at least in the first time.

Yeah. Maybe remove demux_mkv.cpp a month or two after the other has been
tested.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040116/c920efed/attachment.pgp>