[MPlayer-dev-eng] [PATCH] new C only matroska demuxer

[Moritz Bunkus]

Heya,

> When, demux_mkv.cpp was introduced in MPlayer, it was clear that
> a C version of this demuxer would be better, avoiding the linking
> with libstdc++. That's exactly what I've just done. Here is a
> full rewrite of demux_mkv entirely in C and without any
> dependency. It embed the ebml parser.

Nice going! I will test this more thoroughly later. If it works I'd
rather replace demux_mkv.cpp with this one instead of keeping both files
around.

One 'problem' is see: You've written "GPL" for the stuff you (mostly)
copied from gstreamer, but as far as I know it's LGPL and you cannot
just relicense it.

If this checks out ok I'll unify the syntax and the commit it.

> It should work as well as the current C++ version, and even a bit
> better as I implemented lzo compressed vobsub support.

This ain't official - although mkvmerge can use lzo compression as well,
but don't expect it to work anywhere else.

> But I don't have so much matroska files so please test it with yours.

I definitely will. Thanks a lot for the work.

> I kept the current C++ version so you can choose the internal C
> version or the external libmatroska version with the configure
> (like with faad).

Like I said, I'd prefer to replace it. When Ronald and I ported his EBML
and Matroska code to libavformat I got to know his code, and honestly,
there's no use in keeping two demuxers around if the C version is as
good or better.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040115/8ad136d4/attachment.pgp>