[MPlayer-dev-eng] Re: [PATCH] Seek in http-streams

[Alban Bedel]

Hi Valentine Zaretsky,

on Sat, 10 Jan 2004 17:01:19 +0200 you wrote:

> Alban Bedel wrote:
> 
> >>- type of the second argument in streaming_seek callback of 
> >>streaming_ctrl_t structure has been changed to stream_t* (from 
> >>streaming_ctrl_t*) because we need new to open new connection in order
> >
> >>to seek on http and thus close old stream->fd and assign new one, so 
> >>streaming_ctrl_t is not enough
> >>    
> >>
> >
> >I don't really like the idea of changing all these callbacks, etc
> >You can use dup2 to continue to use the old fd.
> >  
> >
> >Dunno however if that will work on win32 and other fancy os.
> >  
> >
> Ok, maybe in this case it would be better not to use streaming_ctrl_t 
> callback at all?
> Using seek callback of stream_t  after checking flags of stream in 
> stream_seek_long seems to be cleaner than my patch and your dup2
> suggestion. What do you think of it?

The problem is that all this code is quiet old now. When it was originaly
writen stream didn't used callback. So Bertrand used callbacks for the
network drivers. But nowaday we have this double callback, that doesn't
much sense.
Getting rid of the callback in streaming_ctl and using the "native" stream
callbacks seems like a good idea to me. But then you then have to modify
all other network drivers.
Bertrand, what do you think of this ?

	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.