[MPlayer-dev-eng] Re: [PATCH] Better handing of ssa subtitle

[matthieu]

matthieu wrote:
> Attila Kinali wrote:
> 
>> Please never send patches direct to me unless i ask for it.
>> Patches should always go to dev-eng
>>
>> On Sat, 07 Feb 2004 00:46:12 +0100
>> matthieu <mat100 at ifrance.com> wrote:
>>
>>
>>> Ok, i have make a new patch that work even if there are no section.
>>> But for better handing in this case I have to decrease the default 
>>> maxcomma to 9.
>>> But if you realy what set it to 32, for no section one, it will work 
>>> like before minus the bug with double comma (",,") that I corrected.
>>> I there are a section, and we are in complex case like
>>> Dialogue: 
>>> Marked=0,0:00:01.00,0:00:05.00,*Default,~,0000,0000,0000,,TOTO,TATA
>>> it will also work.
>>
>>
>>
>> Do you have access to older SSA specs ?
>> I only have the specs for v4+
> 
> me too
> but i had somme old script and it seem that V1 as 8 comma and since v3 
> there are 9 comma.
> 
>> I suspect that this whole patch could be simplified by just decreasing 
>> the max comas number.
> 
> I am not sure because you need to make the difference between 8 or 9 
> commas version. So you need to deternime if between the 8 and 9 comma it 
> is text or effect. But some subtitler seen to put effects that are not 
> in the specs....
> An easy way could be to try to read ScriptType value, but I don't know 
> if all v3+ script have it.
> Or as you can see in v3 script we can use the fact that we need to had 
> Timer or/and Style line before Dialogue in v3+ scripts.
> 
>>
>>             Attila Kinali
>>
> Matthieu
> 
> 
here my last patch that I have test with ssa v1,v3,v4,v4+.

Matthieu

Ps : I my test with ssa v4+ I have enconter a bug in sub_pp_ssa.
In the following script, the test are not cleanned...

Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,Script,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Riz
Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Soupe 
de\nnouilles
Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Saumon
Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Radis
Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Haricots
Dialogue: 
1,0:01:26.58,0:01:28.72,Kare,,0000,0000,0000,,{\shad0}{\bord0}{\1c&HFFFFFF&}{\a3}Pickles
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: subreader3.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040209/0d48354b/attachment.asc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040209/0d48354b/attachment.pgp>