[MPlayer-dev-eng] [Revised Patch] Problem with opening URL's

[Alex Eskin]

Sorry, I attached the wrong file. Here is the patch:



--- Alex Eskin <alexeskin at yahoo.com> wrote:
> Hi 
> 
> I am attaching a revised patch dealing with x-mms-asf URL's
> 
> Description of problem:
> 
> the video/x-mms-asf mime type is ambiguous. It can be
> 
> (1) An asx redirector. This is the most common usage. In fact, most
>    of the windows media on the web today is behind an asx redirector
>    with the video/x-mms-asf mime-type.
> 
> (2) A non-streaming microsoft media (asf) file. 
> 
> (3) An asf stream (live or prerecorded). I have never actually seen
>    one, but I infer from the code that it must exist. 
>    (By the way, if somebody knows a URL of this type, I would be
>      very interested). 
> 
> 
> What does the current code do:
> 
>    It assumes unconditionally type (3). If it gets type (1) or (2)
>    it bails.  This has the effect of breaking most of the windows
> media
>    sites out there. 
> 
>    In fact the current behaviour is probably not intended. The code
>    is basically 
>    if ( content_type == "video/x-mms-asf" ) { 
>          //assume type (3)
>    } else if (content_type == "video/x-mms-asf") {
>           //figure out if it is type (1) or type (2)
>    }
>         
> What does the proposed patch do:
> 
>     It is only a 99% solution. If it gets video/x-mms-url
>     it peeks in the stream to see if there is an asf-streaming
>     header. If yes, it is type (3). If no, then it is type (1)
>     or (2). 
> 
>     It is only 99% because it does not read extra bytes from the
>     socket (it only needs 5 in the buffer). There are other
>     places in the code which do that, and it seems to work well.
>     Still if people want a 100% solution I can recode it. 
> 
> 
> Even if this patch is not it, I hope that some way can be found to 
> solve this issue. 
>      
> 
> Alex Eskin
> 
>  
> 
> 
> 
> 
> 
> --- Alex Beregszaszi <alex at fsn.hu> wrote:
> > X-Mailer: Sylpheed version 0.9.8claws (GTK+ 1.2.10;
> > powerpc-unknown-linux-gnu)
> > X-Face:
> >
>
P)#=xu8^x,lX at 8R?j-t>t]I-rBy@#DCg-z}h4=A&UnH$*ai6L#o)jSFqw39X#:+Cu^Df`8J
> > 
> >
>
Hi`<0;jVqB8IlM:EVC0qYIH<WaL5D4Z?W]aAkZx+M)$h{<~1`fP?\DllJ3svw]9vQ[$#/>O"`dOnRL
> > 
> >
>
dWh}`EV|"@RPB*n'#?ky`!"VT)"L|Erm5]TTDHRBK"#9VeQNkT5[we0vGREjIUInyZOvbmRG
> > X-ColorFace:
> >
>
iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEWjMD3IjWS7SFCphEciCQtfNDbboovGaF/Zw9DAn48BgvVSAAACaklEQVR4nH2UUW+bMBCALU+szxYS2t6QpcavRQiepwneLcKp7aOLdKRvCKm4r0u1xHncoq7tv90ZSJtE0w5icvf5zj5zB0vPBGZhee7VxNAvSfPGK8IPLBEYIaYG/SOnkR4kKfMmNKkxZIlyFJGIsEHTMPIy5+ukSZiy6Y+gmakRIhEHNoG8oXjC0B2ZPDwC/5AZiNAHScIw9dcHSFDQhRGtYpqzUMk4hj7NCdz/eZsEJ7mfVebexavvyu4AXuazW76dgC2AVmhtz3RQvY6mEazrUlmLaPvW9gG8HsBTraVVFnupaPUWRuJB/d1Kq3nMvH2FgV5O4BkWvcIuqDh5Icb8Em5GAKqVC2wXq7WUFKmzrXdhbg1S8kfXXq8c7QyVbcn7jbb7syw1DqsNG5Bi0Wp2MOyWMn8GUHePuNWq42SVnULHgMBlFQB32xguaK6VqhvQcbhlLqu4ZtxeBMOA2AeLvl25T1RXrtNMaxkPvCXc8sESWNYEfleUnI0plRgYo327YXtVEHipUPNedaqNGbDPQ+s2XVYS2AVfoJJSqodLiqkv7GPL6qKkzLMKdKCkZX0M+triwKAoCubwOQANSqqVewAgEAe1BxvzFQIoecwHvJNBJSd7wVCke3ql2rcEp7cEMNrJg8poXxP5RhG5hnqyE/BFtM/GSqihLA7CfkwlmtXFqTA3VeSVdyg/KOXRzODUgTJ/GkF2Cvzpuv0EoD4Hu7m962O7B+PycExKgLHad7/S7BiU8N4GGfizmNdfTv1B/U4NFvkum2X8NJj/dG0ujDC+K+lDQvPDhJSw8cA7eu9ovD3Hpkn/Am1SWgLxwzc/AAAAAElFTkSuQmCC
> > Mime-Version: 1.0
> > Content-Type: text/plain; charset=US-ASCII
> > Content-Transfer-Encoding: 7bit
> > 
> > Hi,
> > 
> > > > > Is there a configuration option I'm missing to get .asx files
> > to
> > > > > stream with the new version of mplayer?
> > > > 
> > > > Try the attached patch.
> > > 
> > > If nobody objects, i'm going to apply this, altough i dont see
> how
> > it
> > > fixes the problem
> > The prob is that MS changed the mime type some months ago, and
> > started
> > using x-mms-asf for asxes... this patch may brake support for older
> > WMA
> > servers
> > 
> > -- 
> > Alex Beregszaszi <alex at fsn.hu>
> > (MPlayer Core Developer -- http://www.mplayerhq.hu/)
> > 
> > _______________________________________________
> > MPlayer-dev-eng mailing list
> > MPlayer-dev-eng at mplayerhq.hu
> > http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 
> __________________________________
> Do you Yahoo!?
> Yahoo! Finance: Get your refund fast by filing online.
> http://taxes.yahoo.com/filing.html

> ATTACHMENT part 2 application/octet-stream name=x-ms-asf.patch
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

__________________________________
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online.
http://taxes.yahoo.com/filing.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x-ms-asf.patch
Type: application/octet-stream
Size: 2038 bytes
Desc: x-ms-asf.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040211/44759693/attachment.obj>