[MPlayer-dev-eng] Correcting printf to mp_msg

[The Wanderer]

Arpi wrote:

> Hi,
> 
>> What MSGL_ should FIXME_MESSAGE_LEVEL (or MSGL_FIXME?) be
>> equivalent to? 5 (STATUS, verbose level 0), because that's the
>> level at which they would be output if left unchanged? Or should
>> there be a complete set of FIXME defines, one for each message
>> level, for versatility?
>> 
>> The latter feels like going overboard, but otherwise I can't
>> specify different message levels without hiding from later review
>> the fact that the level was chosen by someone who doesn't
>> necessarily know what he's talking about.
> 
> I dont know this thread, but i'm against blind changing of printfs to
> MSGT_CPLAYER,MSGL_FIXME or sth like this.
> 
> It's well defined what belongs to MSGT_CPLAYER, and what are the
> given levels are. Just read mp_msg.h:

Yes, it's well-defined what the given levels are, and I did in fact read
mp_msg.h to learn what I know about the subject. But knowing what the
levels are doesn't help me decide which one a particular message belongs
at, unless I *also* understand that part of the code - which, for almost
all parts of it, I currently don't.

And while it may also be well-defined what belongs to MSGT_CPLAYER, or
for that matter the other message targets, I don't know what that
definition is; the simple names and comments in mp_msg.h are of even
less help than for the various MSGLs, and while I can tell that
something in the Gui directory is unlikely to be targeted to the console
player beyond that I don't have much to go on. (I have, for the time
being, stopped using MSGT_CPLAYER; when I resume work, I intend to start
from zero and use MSGT_FIXME or similar, whatever the actual developers
think would be appropriate.)

I'd be much happier to change the printf()s to valid MSGTs and MSGLs,
but since I don't know what would be appropriate in each case and it
would leave nothing to indicate that the choice had been made by (as I
said) someone who doesn't necessarily know what he's talking about, that
would be likely to mess up the G1 code even further than it already is.

-- 
       The Wanderer

A government exists to serve its citizens, not to control them.