[MPlayer-dev-eng] Re: [PATCH] Donald Graft's kerndeint adaptive deinterlacing filter

[Alban Bedel]

Hi D Richard Felker III,

on Sun, 1 Feb 2004 21:15:02 -0500 you wrote:

> On Sun, Feb 01, 2004 at 07:32:53PM -0300, Diego Biurrun wrote:
> >  > > Since your filter does not support things like -vf kerndeint=help
> >  > > or
> >  > 
> >  > WTF? This is not allowed! Filters are not supposed to print help &
> >  > exit. G2 will have a proper way for filters to export help text.
> > 
> > It's called the new config layer (or so I believe):
> > 
> > 
> > akira:/usr/src/mplayer/dev$ ./mplayer -vf scale=help
> > MPlayer dev-CVS-031215-21:24-3.3.2 (C) 2000-2004 MPlayer Team
> > 
> > CPU: Intel Pentium MMX P55C (new) 233.8 MHz (Family: 5, Stepping: 1)
> > Detected cache-line size is 32 bytes
> > CPUflags:  MMX: 1 MMX2: 0 3DNow: 0 3DNow2: 0 SSE: 0 SSE2: 0
> > Compiled for x86 CPU with extensions: MMX
> > 
> > Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file
> > or directory Reading config file /home/diego/.mplayer/config
> > 
> >  Name                 Type            Min        Max
> > 
> >  w                    Integer         -3         No        
> >  h                    Integer         -3         No        
> >  interlaced           Integer         0          1         
> >  chr-drop             Integer         0          3         
> >  param                Integer         0          100       
> >  presize              Object presets  No         No        
> > 
> > 
> > At least some filters do indeed print a help message and exit when
> > called this way.
> 
> Yes, and Albeu drank a whole ocean of cola for that crap. It's total
> nonsense for filters to be able to terminate the calling program.

And it's total nonsense to say that. It's just plain FALSE: RTFS or
shut your mouth !!!! You know your big mouth is sometimes fun, but
you should check your facts before shouting. I mean noadays most of
your posts are not trustable uneless it's about encoding stuff.
Why ? You simply shout too often about stuff you don't really now
about. Imvho you should learn to calm down a bit, and check facts
when needed.

> His
> system also violates the privacy of the _priv_ structure of filters,
> which was named _priv_ for a reason!!

yeah this suck. The reason ? A good bunch of the filters will need
nearly identical option struct and priv struct. It was also needed to
have 100% backward comp. for filter wich still use a simple string as
argument. Don't be stupid there are always reasons behind these kind
of things. Now if you have a better idea feel free to code it ;)

	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.