[MPlayer-dev-eng] Re: [PATCH] Donald Graft's kerndeint adaptive deinterlacing filter

[D Richard Felker III]

On Sun, Feb 01, 2004 at 05:17:49PM -0300, Diego Biurrun wrote:
>  > +Paint pixels which exceed the threshold white (default 0).
>  > +.IPs order (0 or 1)
>  > +Swap fields if 1 (default 0).
> 
> Hmm, why does a flag get a value?  The other filters do it by name,
> i.e.
> 
>   -vf kerndeint=order
> 
> instead of
> 
>   -vf kerndeint=1
> 
> IMHO this is easier to use and it is also more consistent with the
> rest of the filters.

Huh? There is no filter that works like this!

>  > +.IPs thresh (0 - 255)
>  > +Threshold (default 10).
> 
> This appears to be the most important parameter and thus the one that
> will be set the most.  IMHO it should be the first parameter then, so
> that you can do things like
> 
>   -vf kerndeint=100
> 
> instead of
> 
>   -vf kerndeint=0:0:100

Agree.

> Since your filter does not support things like -vf kerndeint=help or

WTF? This is not allowed! Filters are not supposed to print help &
exit. G2 will have a proper way for filters to export help text.

> setting parameter values by name, this seems particularly important to
> me.
> 
>  > +.IPs sharp (0 or 1)
>  > +Enable additional sharping (default 0).
>  > +.IPs twoway (0 or 1)
>  > +Enable twoway sharping (default 0).
> 
> It's sharpENing.

Yes.

Rich