[MPlayer-dev-eng] Re: [PATCH] fix for issue cant play filenames with spaces

[adland]

> How do other protocols behave (mms and such)?

well url_escape_string was called in 2 files http.c as part of
 http_build_request called from network.c http_send_request function and in
 open.c as part of open_stream

the mms:// protocol uses http request so this function was called twice.

the url_unescape_function is called in open.c with your patch
and in m_option.c (part of parse_custom_url unsure if and how this function 
is used myself)

The url_new function is called in open.c, network.c , asf_streaming.c
and cddb.c

I had a different idea recently after testing an initial patch.

remove url_escape/unescape functions from open.c and http.c
 
add fixes to url.c for url_escape and url_unescape
for some issues in these functions

also in url.c url_new function
whenever a new URL is created make sure the uri is first unescaped,
then escaped.

should only happen once per URL instance created 
and would be handled automatically without having to code much.

some initial testing shows this to work well for http test like Compn example,
mms, mmst, rtsp (both real and non)
(both direct and with playlist also both escaped and unescaped input)) 
 
thanks