[MPlayer-dev-eng] Re: [PATCH] MPlayer console output

[adland]

> MPlayer already has a verbosity variable that already
> does exactly this.

did you mean the verbose variable which is initially 0 ?

it doesnt get set to a value based on user verbosity arguments or even used
 with mp_msg_set_level in the beginning of the code execution which was what
 changed.

verbose however is used with mp_msg_set_level at a later time in same file.
probably with a value at this time.

> And lots of your changes are nonsense.  If there's
> an error, leave it as MSGL_ERR.

i see your point but
some messages are ignorable as they are not important like RTC errors
etc. Not a critical problem so decided to make MSGL_V viewable with -v

>  If you don't want to see so much, try
> -quiet.  

okay I looked into this and ran a few tests with CVS build
to see what changed and nothing did for -quiet option..
and only Some few messages changed for -really-quiet option.

code is written so
all messages with levels below or equal to the current level will be shown.

mplayer.c code sets the default level to MSGL_STATUS or 
MSGL_STATUS+verbose , 5 or 5+x depending on location.
 
MSGL values are in mp_msg.h

#define MSGL_FATAL 0  // will exit/abort
#define MSGL_ERR 1    // continues
#define MSGL_WARN 2   // only warning
#define MSGL_HINT 3   // short help message
#define MSGL_INFO 4   // -quiet
#define MSGL_STATUS 5 // v=0

test output
(messages with no option or -quiet option all below are shown.)

CPU: Advanced Micro Devices Athlon 4 /Athlon MP/XP Palomino 1150 MHz
 (Family: 6, Stepping: 2)
Detected cache-line size is 64 bytes
CPUflags:  MMX: 1 MMX2: 1 3DNow: 1 3DNow2: 1 SSE: 1 SSE2: 0
Compiled for x86 CPU with extensions: MMX MMX2 3DNow 3DNowEx SSE

Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file or
 directory
Reading config file /home/unknown/.mplayer/config
Reading /home/unknown/.mplayer/codecs.conf: 65 audio & 174 video codecs
Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file or 
 directory
Reading config file /home/unknown/.mplayer/config

(most of these messages below do go away if you use -really-quiet option)

Linux RTC init error in ioctl (rtc_irqp_set 1024): Permission denied
font: can't open file: /home/unknown/.mplayer/font/font.desc
font: can't open file: /usr/local/share/mplayer/font/font.desc
Try adding "echo 1024 > /proc/sys/dev/rtc/max-user-freq" to your system 
startup scripts.
Using usleep() timing
Can't open input config file /home/unknown/.mplayer/input.conf:
 No such file or directory
Can't open input config file /usr/local/etc/mplayer/input.conf:
 No such file or directory
Falling back on default (hardcoded) input config

>If you want to see none, try a front-end, gui,

thanks but
i would prefer not to use the gui myself.

> or &> /dev/null.
okay
well this is sort of overkill as all messages (not stderr) would then
 disappear