[MPlayer-dev-eng] [PATCH] A filter to inverse-telecine deinterlaced video
Diego Biurrun
diego at biurrun.de
Tue Apr 13 05:42:45 CEST 2004
Ville Saari writes:
> On Tue, Apr 06, 2004 at 10:21:01PM +0200, Diego Biurrun wrote:
>
> > Please escape the - in -ofps with a backslash. This should be done with all
> > option names.
>
> Done. And I also escaped it in phrases like "0-255". New patch attached.
Thanks.
> + "\n%s: Log file ends prematrely! "
nit1: prematUrely
> + "Switching to one pass mode\n", vf->info->name);
nit2: End sentences with a period (also below).
> + "%s: can't create file %s\n", vf->info->name, filename);
> + "%s: can't open file %s\n", vf->info->name, filename);
nit3: I'd use capitalization for a full sentence after a colon.
nit4: There is a lot of trailing whitespace in your code.
Rich, could you have a look at this filter?
Diego
More information about the MPlayer-dev-eng
mailing list