[MPlayer-dev-eng] Re: [PATCH] loader compiler warnings

[Arpi]

Hi,

> > > 
> > > see wine code
> > > in dlls/kernel/path.c function is defined as
> > > DWORD WINAPI GetFullPathNameA( LPCSTR name, DWORD len,
> > > LPSTR buffer, LPSTR *lastpart )
> > 
> > It doesn't matter what's in wine. Our loader comes from avifile.
> 
> this function to my knowledge is only called by external win32 dll files.
> why would you not want to match wine (which avifile loader was based on).

because this code is kept in sync with current avifile, and not with wine.
and avifile is based on 4 yrs old wine, which differs a lot from current one.

> looks like we would want that they are also syncing from us 
> if we have changes to file.

they (avifile) do sync with our code (at least if we send patches),
but improvements only, not cosmetics.

although i'm not mplayer developer any more, i'm against commiting
cosmetics or warning stuff to any code not maintaned by us (be it
loader, libmpeg2, etc).

btw is avifile still developed/maintained, or totaly dead by now?


A'rpi / MPlayer, Astral & ESP-team

--
PyMaViS - my answer to worm storm - http://mplayerhq.hu/~arpi/pymavis/