[MPlayer-dev-eng] Re: [PATCH] loader compiler warnings

[Dominik 'Rathann' Mierzejewski]

On Thursday, 08 April 2004 at 22:31, adland wrote:
> > 
> > Problem:
> > win32.c:3642: warning: assignment discards
> qualifiers from pointer target type
> > static DWORD WINAPI expGetFullPathNameA
> > (
> > ->      LPCTSTR lpFileName,
> >         DWORD nBufferLength,
> >         LPTSTR lpBuffer,
> >         LPTSTR lpFilePart
> > ){
> 
> reply
> 
> see wine code
> in dlls/kernel/path.c function is defined as
> DWORD WINAPI GetFullPathNameA( LPCSTR name, DWORD len,
> LPSTR buffer, LPSTR *lastpart )

It doesn't matter what's in wine. Our loader comes from avifile.

> patch with my suggested change for this function
> 
> comments?

IMHO it's unacceptable, because it actually changes/removes loader code.
Remember, our loader comes from avifile, so any change to original code
means rejected hunks when syncing with avifile's loader. Besides, your
patch does basically the same as mine, so what's the improvement?

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer.html
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"