[MPlayer-dev-eng] [PATCH] altivec color space patch again....
Michael Niedermayer
michaelni at gmx.at
Thu Apr 8 04:00:35 CEST 2004
Hi
On Wednesday 07 April 2004 01:57, Marc Hoffman wrote:
> ok i cleaned up the build environment codes. I hope this helps...
> +#ifdef __APPLE_CC__
> +#define memalign(x,y) malloc(y)
> +#endif
should be replaced by #include "config.h"
[...]
> @@ -281,4 +285,4 @@
>
> printf("%d converters passed, %d converters randomly overwrote memory\n",
passedNum, failedNum);
> return failedNum;
> -}
> \ No newline at end of file
> +}
...
cosmetics
[...]
> static
> vector signed short
> CY = (vector signed short)(0x7fff),
> CRV = (vector signed short)(22972),
[...]
> CY = vec_lde (0, &tmp);
> CY = vec_splat (CY, 0);
non constant statics/globals are forbidden
the yuv2rgb_altivec_init_tables() function also duplicates large parts of
sws_setColorspaceDetails()
the code also calculates some values and never uses them, like:
oy -= 256*brightness;
or
CY = vec_splat (CY, 0);
these 2 will completly break the contrast and brigtness adjustment, and will
even with default contrast and brightness result in y=16 -> r=g=b=16 which is
incorrect
--
Michael
level[i]= get_vlc(); i+=get_vlc(); (violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]); (violates patent #5,905,535)
buf[i]= qp - buf[i-1]; (violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en
More information about the MPlayer-dev-eng
mailing list