[MPlayer-dev-eng] Likely (minor) bug in Real RTSP/RDT demuxing code
Ross Finlayson
finlayson at live.com
Wed Apr 7 06:48:58 CEST 2004
While reviewing the code - in both Xine and MPlayer - for receiving
RealNetworks' 'RDT' data streams:
int real_get_rdt_chunk()
in the file:
real.c
In xine-lib: src/input/libreal/real.c
In MPlayer: libmpdemux/realrtsp/real.c
I noticed the following line:
size=(header[1]<<12)+(header[2]<<8)+(header[3]);
Although I don't know much about Real's protocol, it seems likely that this
should really be:
size=(header[1]<<16)+(header[2]<<8)+(header[3]);
i.e., 16 instead of 12.
This becomes an issue only if the chunk size is >65535, which is probably
why noone noticed it before.
Ross.
More information about the MPlayer-dev-eng
mailing list