[MPlayer-dev-eng] [PATCH] platform independent formats / loaderpatch

[Ivan Kalvachev]

Hi,
There was a discution about similar subject.
It looks like you have missed this reply
   http://mplayerhq.hu/pipermail/mplayer-dev-eng/2004-April/024973.html
in short we could send patch to avifile in order to keep sync.

I don't think that using long on x86 is still safe,
we already have x86-64.

Best Regards
   Ivan Kalvachev
  iive


Dominik 'Rathann' Mierzejewski said:
> First, a few quotes from A'rpi (yes, you're not mistaken, this is from
> December 2002):
>
> Date: Tue, 10 Dec 2002 13:42:24 +0100
> From: Arpi <arpi at x>
> Subject: Re: [MPlayer-dev-eng] [PATCH] Yet another batch of warning fixes
> :->
> [...]
> i mean in avifile sources, the structs (BITMAPINFOHEADER etc) are defined
> twice. once in its include/ (used on all platforms) and once in
> plugins/libwin32/loader/wine/* used only for x86. So, for avifile the
> 'long'
> is ok, as they use the wine headers on x86 only.
>
> but in mplayer, the windef.h is included in stheader.h which is used in
> all
> platforms, including 64bit ones.  the long was changed to int by a patch
> for
> Alpha support long time ago.
> [...]
>
> Date: Sun, 29 Dec 2002 21:58:38 +0100
> From: Arpi <arpi at x>
> Subject: Re: [MPlayer-dev-eng] [PATCH] loader - platform independent
> structures
> [...]
> i said that i'll add the structs (used on non-x86 systems too) to
> stheader.h, so the wine/*.h files won't be used on non-x86 at all
> (used only by the loader and the DLL interface (vd_vfw, _dshow etc) only)
>
> i'm still against changing stuff under loader/ or any only-imported (not
> developed in mplayer cvs) libs.
> [...]
>
> And now, the patch.
>
> I created two additional files (basically, copy&paste and replacing DWORD
> etc with uintXX_t) in libmpdemux/ - avifmt.h and formats.h which get
> included on non-x86 platforms instead of the headers from
> loader/wine/{mmreg,avifmt,vfw}.h. I also moved WAVEFORMATEX and
> BITMAPINFOHEADER definitions from stheader.h to formats.h. Finally, I
> re-synced the definitions of DWORD, ULONG (in windef.h) and
> BITMAPINFOHEADER (in vfw.h) with latest loader sources from
> avifile-0.7.38.
>
> So far I've been able to verify that it doesn't break anything
> (compilation,
> vfw dll decoding) on x86. Sascha said it compiles for him on win32.
> I also verified it compiles on Alpha yesterday.
>
> Note: this is an RFC, it's not meant to be applied as-is.
>
> Regards,
> R.
>
> --
> MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer.html
> "The Universe doesn't give you any points for doing things that are easy."
>         -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>