[MPlayer-dev-eng] [PATCH] palette
Joey Parrish
joey at nicewarrior.org
Sun Nov 23 18:11:39 CET 2003
On Tue, Nov 18, 2003 at 11:10:15PM -0500, D Richard Felker III wrote:
> > > > This patch is for vf_palette. The problem is that vf_palette
> > > > uses conversion routines that assume that the palette itself
> > > > is the same depth as the output colorspace. So if it outputs
> > > > to 16 bit space, then it thinks the pal is 16-bits. I don't
> > > > know where this would be true, but all my palette'd 8-bit avi's
> > > > and gif's and fli's all have 24-bit palette. Since I'm not
> > > > about to rewrite the rgb2rgb code, I instead comment out support
> > > > for BGR/RGB 15/16 in vf_palette. Now they will output correct
> > > > images to 24 or 32 bit colorspace, and if the vo needs 15 or 16,
> > > > vf_scale will do it's job and convert correctly.
> > > >
> > > > Comments? Is this patch okay?
>
> I didn't say it was not ok, just slow. :) If the old code was broken,
> feel free to commit your fix, as long as it doesn't slow down the case
> that was already working.
Committed.
--Joey
--
"Living in the complex world of the future is somewhat
like having bees live in your head. But, there they are."
More information about the MPlayer-dev-eng
mailing list