[MPlayer-dev-eng] [Patch] get_total_time for ogg

[Michael Behrisch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Montag, 10. November 2003 13:33 schrieb Moritz Bunkus:
> Hi,
>
> > But the stream from which the granulepos is used is determined by
> > the same code in ogg_scan_stream as well as in ogg_control.
>
> You might be right, but you shouldn't do it that way anyway. What if the
> last 20 pages do not contain packets for the video stream? What if, with
> all those additions being made to demux_ogg lately (Theora, Flac,...),
> this is not true anymore? Using the timestamp just abstracts from 'the
> os used when findind the biggest granulepos is the os that is used in
> _control' and therefore safer. And as there's probably no one who REALLY
> knows all about the ogg demuxer we should take the safe approach.

Sorry for answering this late but I could not fix the patch the way you 
wanted it. The problem is IMHO that when ogg_open is called the samplerate
may be not known yet because the vorbisinfo is generated by the audiodecoder.
Thus it's impossible to save anything but the granulepos.

Michael

P.S: Although demuxer.c has changed the patch is still valid and I would still
ask for applying it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE/uIYCZDyR4hR8HnQRApBqAKDcHXqav/UsRKBmMWTdm8uZadbkFACgqrMw
KEzS1fw3KWtCWJb6X5zsz5A=
=w8fL
-----END PGP SIGNATURE-----