[MPlayer-dev-eng] [PATCH] libmpcodecs/vd_ffmpeg.c compile problem

[rgselk]

--- Roberto Togni <r_togni at tiscali.it> wrote:
> On 2003.11.10 22:19, rgselk wrote:
> > With the current cvs version of libavcodec (4684) I get a compile
> > error
> > on  AVPALETTE_SIZE.
> > The attached patch fixes it for me. However I am not sure about the
> > version number...
> > 
> > Regards,
> >   rgselk.
> Committed a modified version. BTW, current CVS is 4692.

That is not what I get. I still get 4684:

rgselk[~/MPlayer/libavcodec](20484): cvs update -Pd -A
cvs server: Updating .
M h263.c
cvs server: Updating alpha
cvs server: Updating armv4l
cvs server: Updating i386
cvs server: Updating liba52
cvs server: Updating libac3
cvs server: Updating libpostproc
cvs server: Updating mlib
cvs server: Updating ppc
cvs server: Updating ps2
cvs server: Updating sh4

rgselk[~/MPlayer/libavcodec](20485): grep BUILD avcodec.h    
#define LIBAVCODEC_BUILD       4684
#define LIBAVCODEC_IDENT        "FFmpeg" LIBAVCODEC_VERSION "b"
AV_STRINGIFY(LIBAVCODEC_BUILD)
/* returns LIBAVCODEC_BUILD constant */

rgselk[~/MPlayer/libavcodec](20486): cat CVS/Root 
:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg


> 
> > +#if LIBAVCODEC_BUILD >= 4689
> >  	// Palette support: free palette buffer allocated in
> > get_buffer
> >  	if ((mpi->bpp == 8) && (mpi->planes[1] != NULL))
> >  		free(mpi->planes[1]);
> > -
> > +#endif
> This is not needed IMHO. There are no references to libavcodec
> symbols.

You are freeing data which was malloc'd within an #ifdef. If malloc is
within #ifdef, the free should be in the same kind of #ifdef.

Regards,
  rgselk.


__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree