[MPlayer-dev-eng] [PATCH] libvo/w32_common.c minor corrections

[Reimar Döffinger]

Hello!
> This doesn't look right imho.
> It will always changes the video to fullscreen during mode change. I don't
> understand
> how you will be able to switch back from fullscreen to windowed with this.
> Furthermore it won't preserve the aspect ratio.

First of all: I originally left out the "if (vo_fs)" by accident, but it 
isn't needed because changeMode is only called when vo_fs is set, 
otherwise resetMode is called.

1) I did test it, and I could not see any wrong behavior
2) This is exactly the way it is done in x11_common.c - although it is a 
  bit difficult to find. And this is the most important reason I want to 
change it. ( see x11_common.c, lines 1048, 1056, 730 ). At least the 
windowmanagers I use don't apply the aspect hints to fullscreen windows 
- I don't think this would make sense anyway.
3) You can switch back to windowed because the old window size is stored 
in o_d{width,height}. This is currently done by the vo module, maybe 
this should be changed, but I didn't want to change w32_common.c 
completely. Btw. vo_dwidth and vo_dheight would be changed by the call 
to aspect anyway.

But maybe we should first discuss what vo_dwidth and vo_dheight are 
supposed to mean. I think it makes most sense if they simply tell the 
ouput module how much area is available for drawing into, it may decide 
itself how to use it best. (for example depending on whether hardware 
scaling is available, if the OSD is drawn on the video frames or 
directly on screen etc.)

I hope I'm getting nearer to convince everyone ;-).

Greetings,
   Reimar Döffinger