[MPlayer-dev-eng] [PATCH] libvo/w32_common.c minor corrections

[Tristan Seligmann]

On Fri, Nov 07, 2003 at 15:24:41 +0100, Reimar D?ffinger wrote:
> >A better fix would probably be to make the RegisterClass handle the
> >class being already registered.
> 
> I guess I can do that, but I'm usually of the opinion "If we created it, 
> we should free it" althought it is freed by windows when the process 
> exits. Maybe best solution would be to do both.

I suppose it doesn't matter much either way.

> No (unless I did something very stupid while testing this patch), I used 
> -aspect with different values and both vo_directx and vo_gl2 still 

vo_directx does not (afaik) use this code; it was written by myself to
parallel x11_common when I ported vo_gl2 to win32.

> worked the same as before. I know that vo_gl2 calls aspect itself when 

Well, it doesn't work for me. Take a file with an aspect ratio different
to my screen resolution, play it in fullscreen without your patch, and
it comes up at the correct aspect ratio, with black bars above and
below. With your patch, it is stretched to the full size of the screen,
and thus is distorted vertically.

mithrandi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031107/8e58715a/attachment.pgp>