[MPlayer-dev-eng] [PATCH] libvo/w32_common.c minor corrections

Tristan Seligmann mithrandi-mplayer-dev-eng at mithrandi.za.net
Thu Nov 6 23:18:46 CET 2003


On Thu, Nov 06, 2003 at 20:43:18 +0100, Reimar D?ffinger wrote:
> 1) Adds a call to UnregisterClass in vo_w32_uninit. This makes vo_gl2 
> work with multiple files on the commandline without using -fixed-vo. I 
> think it belongs here anyway.
> Doesn't seem to affect vo_directx.

A better fix would probably be to make the RegisterClass handle the
class being already registered.

> 2) when using fullscreen mode it sets vo_d{width, height} to 
> vo_screen{width, height} instead of calling aspect with A_ZOOM. This 
> makes it consistent with the x11 functions and it probably makes more 
> sense to let the output module decide whether to use aspect scaling (for 
> example in the case of lacking HW scaling).
> Doesn't seem to affect neither vo_directx nor vo_gl2.

Well, with all the other vo modules I've tried, if you play something
in fullscreen, it preserves the aspect ratio when stretching it to the
size of the screen; I haven't had a chance to test this patch, but won't
the image now be stretched to the full size of the screen, regardless of
the aspect ratio?

mithrandi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20031107/502e71a4/attachment.pgp>


More information about the MPlayer-dev-eng mailing list