[MPlayer-dev-eng] Re: [Mplayer-cvslog] CVS: main/DOCS/en codecs.html,1.124,1.125

[Linards Ticmanis]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arpi wrote:
> Hi,
>
>
>>>IMO the argument for including faad is that the source package is
>>>usually broken and has idiotic dependencies (like libsoundfile or
>>>whatever). Same situation as dvdread/dvdcss when they were first
>>>imported to mplayer cvs. On the other hand, lame and vorbis libs are
>>>generally non-broken. Also lame is only needed for mencoder, which
>>>most people don't seem to use.
>>
>>I agree, provided we could make faad work without libsndfile.
>
>
> of course it works without it.
> i've just commited libfaad2 dir and the requires changes to
> makefile/configure/ad_faad.c
>
> please test the code, it should work on all platforms.

It doesn't. GCC 3.2 on an x86-Linux / Pentium 4 chokes on it.

> make -C libfaad2
> make[1]: Entering directory `/home/linards/mpmod/libfaad2'
> gcc -c -I. -O4 -march=pentium4 -mcpu=pentium4 -pipe -ffast-math
- -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE
- -D_FILE_OFFSET_BITS=64  -o bits.o bits.c
> gcc -c -I. -O4 -march=pentium4 -mcpu=pentium4 -pipe -ffast-math
- -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE
- -D_FILE_OFFSET_BITS=64  -o cfft.o cfft.c
> cfft.c:556:2: warning: no newline at end of file
> cfft.c: In function `passf2':
> cfft.c:556: unable to find a register to spill in class `FLOAT_REGS'
> cfft.c:556: this is the insn:
> (insn 239 237 250 (set (subreg:SF (reg/v:DI 29 rmm0 [112]) 0)
>         (minus:SF (mem:SF (plus:SI (mult:SI (reg:SI 1 edx [114])
>                         (const_int 8 [0x8]))
>                     (reg/v/f:SI 3 ebx [62])) [4 S4 A32])
>             (reg:SF 8 st(0) [134]))) 533 {*fop_sf_1_nosse} (insn_list
236 (nil))
>     (expr_list:REG_DEAD (reg:SF 8 st(0) [134])
>         (nil)))
> cfft.c:556: confused by earlier errors, bailing out
> make[1]: *** [cfft.o] Error 1
> make[1]: Leaving directory `/home/linards/mpmod/libfaad2'
> make: *** [libfaad2/libfaad2.a] Error 2

- --

Linards Ticmanis

 The Master said, "The business of laying on the colors follows the
preparation of the plain ground."




-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE/UesRpXWZ5wbYWboRAuKsAKCQDdYolSnxHo0mkjSYilwwlnD10QCeKVQV
j0yAdVmKL5oRONVPR7Y8wn4=
=Cebp
-----END PGP SIGNATURE-----