[MPlayer-dev-eng] Re: [PATCH] ftp support

[Alban Bedel]

Hi Alex Beregszaszi,

on Wed, 13 Aug 2003 15:12:49 +0200 you wrote:

> Hi,
> 
> just some comments to ftplib:
> would you please better integrate it into mplayer?
yes

> * remove the strdup,memccpy and other osdep/ related funcs
ok

> * remove net_* and use our conventions for win32 vs unix support
What do you mean ? Afaik we only settled to uss recv wich is avaible
everywhere. And here it use a define. Imho it's ok. No need to mess
with that.

> * remove static char *version and such
ok (2 vars :)

> * probably you could use the existings network.c network reading/writing
> api
I tried but i dunno if it's really worth it. This is alredy coded to be
portable on windows. So just changing the defines to use ours should be
enouth. The only advantage (i can see) with using our connect2server
is for IPv6 support. But supporting IPv6 mean also some change for
the passive mode (and passive is the default). So imho it's not worth
it.
	Albeu

-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.