[MPlayer-dev-eng] Re: [PATCH] softpulldown

[Arpi]

Hi,

> sllssslllsssllls
> IPBBPBBPBBPBBIBB
> 
> And if I insert a printf in there I see the latter pattern (well, until
> telecine detection kicks in, so it probably really doesn't matter).

hmm, i'll check.

> > > Two other things I noticed:
> > > 1) In mplayer.c, VOCTRL_DUPLICATE_FRAME is only called if
> > >    vo_config_count>0, but vo_config_count is not increased by the
> > >    yuv4mpeg output plugin.
> > 
> > it's increased by (and ONLY by) vf_vo.c
> 
> Ok I missed that because I only grepped in libvo...
> However grepping shows that vo_xvidix and vo_xover increase it
> themselves at the end of their config function.

then they are buggy.
anyway it doesnt matter too much, as thsi variabel is only checked for zero,
so if it's 2 instead of 1, no one cares.

> > > 2) This filter does not work properly with vo_yuv4mpeg because
> > >    it supports slices and only writes a frame on flip_page.
> > >    AFAICS there is no big benefit to slices support in vo_yuv4mpeg
> > >    (As far as I understand it slices are needed for direct rendering),
> > >    so would it be ok to disable slices support of vo_yuv4mpeg?
> > 
> > no!
> > 
> > i don't understand how slices are related to your filter?
> > if your filter doesn't support slices, things still should work, vf_vo.c
> > does handle this case.
> 
> The thing is that I sometimes call vf_next_put_frame twice in my

argh
it is not allowed to output more than one frame!
at least for playback, encoder should be able to handle it.

why don't you write such filters for mplayer-G2 instead?


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu