[MPlayer-dev-eng] [PATCH] Huge batch of compiler warning fixes

[Jindrich Makovicka]

Dominik Mierzejewski wrote:

>On Monday, 04 November 2002, Arpi wrote:
>  
>
>>Hi,
>>
>>    
>>
>>>A couple of patches, actually:
>>>First one adds -Wall to CFLAGS in places they were missing, so that we
>>>can catch all warnings.
>>>      
>>>
>>_WHY_ ?
>>    
>>
>
>Why? To annoy developers into cleaning up their code, for example. :-) I
>thought we're almost done with killing all warnings after my previous
>patch, but then I noticed that not every Makefile sets -Wall, so I added
>it. And boom! Few lines of warnings turned into few hundred. We shouldn't
>turn a blind eye on that.
>  
>
Yes, nowadays there are so many warnings that they lose their meaning 
because you simply have to ignore them. I tried to check all the 
warnings generated by --enable-debug twice, and in both cases I found at 
least one real bug (well, no surprise when the 2> output was about 
100Kbytes).

-- 
Jindrich Makovicka