[MPlayer-dev-eng] [PATCH] ve_xvid bug fixes, cleanup & enhancements

Arpi arpi at thot.banki.hu
Sat Nov 2 19:00:11 CET 2002


Hi,

> 1) It seems the CONF_TYPE_SUBCONFIG array for the "mode" option eats
>    all other -xvidencopts parameters. With it it wasn't possible to
>    set the bitrate or in fact any other parameter beside "mode".
> 
> 2) xvidenc_param declared static, no need to pollute the name space.
>    It will be probably nicer to convert to a set of static variables
>    like in ve_lavc.c (easier to initialize) but I will do it in
>    another patch if needed.
> 
> 3) xvidencopts_conf wasn't properly initialised for some of the
>    lines. Probably didn't cause bugs but at least this patch shaves a
>    few gcc warnings.
> 
> 4) Added "lumi_mask" & "mpeg_quant" options.
> 
> 5) Changed the interpretation of "br" to be consistent with lavc (now
>    in kbits/s if <16000, else bits/s). Should be backward compatible.
> 
> 6) Patched mplayer.1 too.

nice, i'll commit (later, as now my local tree is fsck'd up with debug stuff)

btw, if you want, and no objections by others, i'll give you CVS write
access. send me wanted login/pass in private.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list