[MPlayer-dev-eng] GUI DXR3 Config patch

Zoltan Ponekker pontscho at kac.poliod.hu
Sat Nov 2 16:29:03 CET 2002


Hali

> > I have rewritten the way the gui handles DXR3 config and added support for
> > setting TVOut/Overlay.
> > If the attached patch looks ok I will add support for activating prebuffering,
> > sync and selecting video output mode (NTSC/PAL).
> >
> > Do NOT apply this patch. It changes the way you configure the dxr3 and I must
> > update the docs first.
>
> -#ifdef HAVE_DXR3
> - if ( !gtkDXR3Device ) gtkDXR3Device=strdup( "/dev/em8300-0" );
> -#endif
>
> why ?

+ /* These are only used internally to load config */
+ int gtkDXR3Prebuf = 0;
+ int gtkDXR3Sync = 0;
+ int gtkDXR3Overlay = 0;
+ int gtkDXR3Device = 0;

Bad idea, use dxr3 variables (prebuf, sync, overlay ... ), and define the
variable with unique name. :)

Pontscho / fresh!mindworkz
---
MPlayer Core Team - www.MPlayerHQ.hu




More information about the MPlayer-dev-eng mailing list