[MPlayer-dev-eng] [PATCH] bugfix vo_png vo_gif89a

[Joey Parrish]

On Mon, May 13, 2002 at 11:32:50PM +0200, Arpi wrote:
> it's already in the cvs, and in just released pre4 :)

YAY!  XD

> anyway, i get errors, and libungif not detected due to this:
> 
> ============ Checking for GIF89a support ============
> 
> #include <gif_lib.h>
> int main(void) {
>   return 0;
> }
> 
> gcc    /tmp/mplayer-conf-23021-2703.c -o /tmp/mplayer-conf-2739-2703.o
> -lungif
> /usr/lib/libungif.so: undefined reference to `XDestroyImage'
> /usr/lib/libungif.so: undefined reference to `XGetWindowAttributes'
> /usr/lib/libungif.so: undefined reference to `XGetImage'
> /usr/lib/libungif.so: undefined reference to `XGetPixel'
> /usr/lib/libungif.so: undefined reference to `XQueryColors'
> collect2: ld returned 1 exit status
> 
> ldd /tmp/mplayer-conf-2739-2703.o
> ldd: /tmp/mplayer-conf-2739-2703.o: No such file or directory
> 
> dunno why depends libungif (libgif is symlink to ungif here) on X11.
> it's Slackware 8.0, distro's default libungif package.

Hrm, well I dug the answer out of libungif's source code.
It seems that there is optional support for using libungif
to take direct X11 screenshots.  Seems odd to me that anyone
would use a gif library to do that directly... but I suppose
some package maintainers build that option in.  Here's yet
another patch (are you sick of me yet? :) to configure.
Does this get libgif autodetected on Slackware?

Thanks.
--Joey

-- 

"Yes." -- John F. Kennedy
-------------- next part --------------
--- configure.orig	Mon May 13 16:06:10 2002
+++ configure	Mon May 13 16:45:29 2002
@@ -2342,12 +2342,18 @@
   return 0;
 }
 EOF
-  if cc_check -lungif && "$TMPO" >> "$TMPLOG" ; then
+  if cc_check -lgif && "$TMPO" >> "$TMPLOG" ; then
+    _gif=yes
+    _ld_gif="-lgif"
+  elif cc_check -lgif -lx11 && "$TMPO" >> "$TMPLOG" ; then
+    _gif=yes
+    _ld_gif="-lgif -lx11"
+  elif cc_check -lungif && "$TMPO" >> "$TMPLOG" ; then
     _gif=yes
     _ld_gif="-lungif"
-  elif cc_check -lgif && "$TMPO" >> "$TMPLOG" ; then
+  elif cc_check -lungif -lx11 && "$TMPO" >> "$TMPLOG" ; then
     _gif=yes
-    _ld_gif="-lgif"
+    _ld_gif="-lungif -lx11"
   fi
 fi