[MPlayer-dev-eng] Re: [PATCH] Read extended (>2GB) AVI files

[Arpi]

Hi,

> >most of the patch replaces int by long, it has no effect on x86
> >they are both 32 bit
> 
> Actually some of it replaces int by off_t, which is 64bit when
> compiling with --enable-large-files (which is of course mandatory when
i know

> you want any kind of support for >2GB).  In strategic places, the
> demux_... functions are used as to maintain a proper 64bit offset.
> The fields within the AVI headers must still remain 32bit.  Therefore,
> not everything can be transformed to off_t.

yes, but your conversions from int to long are bad, as long is 64bot on
64bit cpus like alpha, while it's 32bit on 32bit cpus liek x86

could you rework the patch to do the minimal changes, from int to off_t
where it is needed? int->long is nonsense and even may be wrong


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu