[MPlayer-dev-eng] [PATCH] Reverse vop order in command line

[Fabian Franz]

Is this patch really not useful to someone ??? :-(

cu

Fabian

Am Donnerstag, 18. Juli 2002 23:42 schrieb Fabian Franz:
> Hi!
>
> [Short Desc]
> This patch reverses the order of the vop-filters, when the command line is
> parsed...
>
> So the right direction for the applying of the video-filters is again:
> left-to-right...
>
> I hope this is usefully ...
>
> [Long]
> I myself did not realise that the order of the -vop-filters was
> right-to-left until i read the attached mail ...
>
> I read:
>
> "[mplayer-dev-eng] -vop scale"
>
> > On Thursday 18 July 2002 01:03, Felix Buenemann wrote:
> > Btw. I'm still for changing specification order of -vop, because it's
> > fully unatural now, (most) people think and write from left to right, so
> > even when you know that the order is reversed, you always start shuffling
> > around with the curser to get it all right.
> > I know it's already quite late for this, but I think it's worth the
> > change and many(?) users do this wrong, too. I asked Arpi about this long
> > time ago, he agreed but never changed it... (I had a go at it myself back
> > then, but failed miserably for some obscure reason ;)
>
> and decided to make a patch.
>
> As this is my first patch to mplayer i read the
> http://www.mplayerhq.hu/DOCS/tech/patches.txt several times and checked it.
>
> And first of all i had to find a suitable location for my patch ...
>
> I think that the vop-filters are accessed in the reverse order, because new
> filters specifically to the codecs are added to the end and those have to
> be executed first ...
>
> Correct me if i'm wrong ...
>
> So the only suitable and easy to find place was there, where the command
> line is parsed ...
>
> And, because the -loop-option is parsed there as well, I decided to place
> my code there ...
>
> I also tried to look through the file to find suitable parsing-code ...
>
> What I didn't know was, how it is with memory checking after malloc or
> calloc ...
>
> Sometimes it is checked, sometimes it is not...
>
> As I need a calloc in my code, I don't know how to handle this ...
>
> I hope you understand and like my first patch ...
>
> And then I wanted to say: MPlayer is really great work!
>
> Best wishes,
>
> Fabian