[MPlayer-dev-eng] (yet) another batch of compiler warning fixes

[Felix Buenemann]

On Thursday 11 July 2002 16:52, Felix Buenemann wrote:
> On Wednesday 10 July 2002 21:02, Joey Parrish wrote:
> > On Wed, Jul 10, 2002 at 11:14:40AM +0200, Dominik Mierzejewski wrote:
> > > They're still not applied, but nobody said they were bad last time
> > > I sent them.
> >
> > There's only one problem that I see, and that's that this hunk:
> >
> > -typedef unsigned long ulong;
> > +/* typedef unsigned long ulong; */ /* already defined in <sys/types.h>,
> > which is included by <stdlib.h> */
> >
> > causes problems on cygwin.  Under cygwin, ulong is never defined
> > in any standard headers.  I suggest something like this:
> >
> > +#if defined(__CYGWIN__)
> >  typedef unsigned long ulong;
> > +#endif
> >
> > and if there are any other systems that have no ulong def, then
> > they can be added to the #if defined line.
>
> if it only affect cygwin, it could be added to the cygwin_inttypes.h file.
I just see, that it is only used in mplayer-internal code, in this case it is 
best to simply replace all usage of ulong in the code by unsigned long, as it 
is the standard syntax.
> > --Joey

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________