[MPlayer-dev-eng] [PATH] libmpdvdkit and tvi_bsdbt848 on NetBSD

[Bernd Ernesti]

On Sun, Apr 28, 2002 at 12:15:39PM -0700, Steven M. Schultz wrote:
[..]
> > Thats a way to test for HAVE_LINUX_DVD_STRUCT, at least on NetBSD and I guess
> > it is the same on FreeBSD, BSD/OS and maye on OpenBSD.
> 
> 	How is checking for '<dvdio.h>' and '<dvd.h>' a way to test for
> 	HAVE_LINUX_DVD_STRUCT?

I don't know what FreeBSD uses.

NetBSD uses the HAVE_LINUX_DVD_STRUCT in <dvdio.h>.

> 	I think we are in agreement that it is better to test for .h files
> 	rather than trying to guess an OS type.

That would work if <dvdio.h> always means HAVE_LINUX_DVD_STRUCT.

> 	Instead of "BSD" style and "Linux" style check  for <dvdio.h>, if it
> 	is present then use it without classifying the system as "BSD" or
> 	"Linux".   I doubt that a system will have both dvdio.h and dvd.h
> 	but if it does then include both of them.

I think we should use the current way since it works now.

> 	Instead of HAVE_BSD_DVD_STRUCT and HAVE_LINUX_DVD_STRUCT and 
> 	DVD_STRUCT_IN_DVD_H and DVD_STRUCT_IN_BSDI_DVDIOCTL_DVD_H and so on
> 	perhaps simply HAVE_DVDIO_H and HAVE_DVD_H would be a better way?

If HAVE_DVDIO_H and HAVE_DVD_H have the same structs  on all system.

> 	It does seem to be more general and less prone to guessing incorrectly.

But that would also mean you are changing the code so it has more changes to
the libdvdcss source.

Bernd