[MPlayer-dev-eng] [PATH] libmpdvdkit and tvi_bsdbt848 on NetBSD

[Bernd Ernesti]

On Sun, Apr 28, 2002 at 11:44:53AM -0700, Steven M. Schultz wrote:
> Hi!
> 
> > From: Arpi <arpi at thot.banki.hu>
> > 
> > from the prev patch, sugegsts that netbsd has linux-style dvd

Correct, I was about to send an answer, but had to wait to get the digest
mail (and now back to the non digest mails).

Thats why his configure change is correct on netbsd.

> 	Ah, ok.  I have FreeBSD, Linux and BSD/OS systems but not a NetBSD
> 	one (yet;)).   I know FreeBSD has <dvdio.h> instead of <dvd.h>

NetBSD has also <dvdio.h>.

> > is there a way to detect the type of dvd struct, instead of hardwiring to
> > os?
> 
> 	I was going to make that suggestion ;)
> 
> 	Testing for capabilities and .h files would be much better than
> 	hardwiring by OS type.
> 
> 	My suggestion (which will work for FreeBSD and BSD/OS) is soemthing
> 	like this:
> 
> 	Check for <dvdio.h>, if it exists then check that something like
> 	"struct dvd_struct foo;" will compile.   If it succeeds then "BSD"
> 	style is present.

Are you sure that you don't mix it up again?

Thats a way to test for HAVE_LINUX_DVD_STRUCT, at least on NetBSD and I guess
it is the same on FreeBSD, BSD/OS and maye on OpenBSD.

Bernd