[MPlayer-dev-eng] Re: [PATCH] endian fixes for ASF streaming

[Bertrand Baudet]

I looked at the patch and made a rework of it.

mplayer already uses macros for endian handling, 
so it will avoid those blocks of #if WORDS_BIGENDIAN
I created a new endian macro for the ASF_chunk_t and
applied it just after reading the data, this should avoid
that Arpi was explaining below.
I also changed the asfheader file to use those macro
and added one endian handling that was missing.

I hope this will fix the big endian issue, please Guillaume test it
and let me know. Merci 

Bertrand


On Saturday 13 April 2002 06:29 pm, you wrote:
> Hi,
>
> > Arpi,
> >
> > Thanks to have applied the asfheader.c patch. However, I'd like to know
> > why you have not applied the asf_streaming.c patch. I've just tested the
> > code without it, it does not work :
>
> because it is not my code... the network maintainer should check that.
> anyway, i'm not sure your patch is correct, it should do endian swap
> when first time filling those variables, instead of in a function which
> use these values. what happens if this function is called second time?
> it will swap back the values... mayeb it is never called twice, i don't
> know. Bertrand should know...
>
>
> A'rpi / Astral & ESP-team