[MPlayer-dev-eng] fixing mencoder

[D Richard Felker III]

On Wed, Apr 10, 2002 at 10:17:02PM +0200, Arpi wrote:
> Hi,
> 
> > 
> > hmm....actually i think i understand how this stuff works a bit better
> > now. maybe it would be appropriate to just lock out_fmt to yv12 for
> > lavc or divx4 encoding, and have mencoder's query_format function
> > return false for any other formats. of course, that's essentially what
> > my previous hack did, albeit with an extra pseudo-filter in between.
> > sound good?
> 
> it'a ALREADY done.
> hint: query_format() in mencoder.c

well, query_format accepts several different formats. this is
problematic because the output format which will be given to the
encoder needs to be known when initializing the encoder...but with the
new architecture, that's not known until the video decoder configures
the filters/vo. so, in the meantime (until you get it fixed properly)
the only workaround i can see is to ensure that the encoder is always
given the same format, which is known in advance before encoding
begins. either the format plugin hack (which i already did) or having
query_format just accept one format (rather than several like it does
now) would accomplish this, although it naturally limits flexibility a
bit in what decoders are available. using the scale plugin can of
course work around that problem.

> > in all these cases, i suppose it'll fail if the decoder can't output
> > yv12, but it's certainly better than mencoder not working at
> > all. and of course the user can just tell the scale plugin to convert
> > to yv12 if needed...
> > 
> > thoughts on all this?
> 
> stop this, i'm WORKING on this and it will be no more problem few days later
> (automatic conversion etc)

yeah, i got your other email just after i sent this. i've stopped
now. :) you can take it from here -- apologies if this whole thing
caused trouble or annoyed you.


rich