[MPlayer-dev-eng] [PATCH] Proof of concept extrasurround plugin

Anders Johansson ajh at atri.curtin.edu.au
Fri Apr 5 09:58:00 CEST 2002


Hi,

Had a quick look at the problem try changing the last line in
get_space() in ao_plugin to :

return (int)(sz+0.5);

If you have time, I don't have time to test it at the moment...

//Anders

> On Thu, Apr 04, 2002 at 11:12:11PM +0200, Felix Buenemann wrote:
> > On Thursday 04 April 2002 22:03, Kis Gergely wrote:
> > > -> Included "quick workaround" for ao_plugin.c bug that prevented 6 channel
> > >     output in many cases. This is not a true fix, it may cause problems for
> > >     you.
> > could you give a more detailed description about this?
> In ao_plugin.c in the play() method in some cases when using 6 channel
> output the ao_plugin_data.len is set to size(ao_plugin_data.data)-1
> Because in case of s16_le format the sample size is always a dividable by 2
> I added this quick and dirty and uncomplete and ugly code to ao_plugin.c
> play()
> 
> if (ret_len % 2 !=0) {
> 	ret_len += 1;
> } 
> 
> And it worked. But for another afmts it will probably not work as expected.
> 
> The real problem is probably in get_space() but my knowledge of the ao
> architecture is very limited and I think somebody from the developer team
> could fix it more accurately. 
> 
> 
> Bye,
> kisg
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng



More information about the MPlayer-dev-eng mailing list