[MPlayer-dev-eng] [PATCH] display DVD subtitles

[Felix Buenemann]

On Thursday, 22. November 2001 01:44, you wrote:
> On Wed, Nov 21, 2001 at 01:05:31AM +0100, Felix Buenemann wrote:
> [...]
>
> > > > also an important limitation:  color+alpha must be less or equal to
> > > > 255 (because there is no >255 range checking and clipping)
> > >
> > > OK, this explains all the strange things I was experiencing...  With
> > > the following patch subtitles are now stable and readable on all the
> > > DVD's I have.  I hope the color picking heuristic is good enough for
> > > most person.
> >
> > it's bad for me, with the matrix dvd I have I get withe outline sub with
> > tranparent text.
> >
> > I also did some simple heuristics like the following:
> > alpha0: area around sub/background: always 0 -> transparent
> > alpha1: subtitle: always 1 -> opaque
> > alpha2: dunno what used for: always 1 -> opaque
> > alpha2: subtitle outline: always 127 -> 50% transparent
> >
> > color[x] 0 or 15: 0 -> transparent
> > else 195 -> nearly opaque
> >
> > see attached patch against current cvs.
> >
> > Please test if it's correct for you in all cases.
>
> [...]
>
> FWIW:
>  - both patchs works for Fightclub DVD:
>    atmos's patch: subtitles opaque => OK
>    Kim's patch: outline of subtitles white opaque => OK
>
>  - for Being John Malkovich DVD:
>    atmos's patch: weird displays, varying on the -vo used (but never
>      correct)
>    Kim's patch: subtitles look OK (white opaque)
>
> I guess the "Colors need to be parsed from the IFO." comment may be
> related to this behavior. (?)
yea, I guess we really need that info...
-- 
Best Regards,
	Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________